Hi Andy, On Mon, 21 Oct 2019 at 01:55, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > > On Mon, Oct 21, 2019 at 6:32 AM Simon Glass <s...@chromium.org> wrote: > > > > Apollolake is an Intel SoC generation aimed at relatively low-end embedded > > systems. It was released in 2016 but has become more popular recently with > > some embedded boards using it. > > > > This series adds support for apollolake. As an example it adds an > > implementation of chromebook_coral (a large range of Chromebooks released > > in 2017). > > > > The series provides enough support to boot to a prompt. with LCD display, > > storage, USB, EC and keyboard. > > > > Since this is the first time U-Boot has used FSP2 there is quite a bit of > > refactoring needed. > > > > Thanks for doing this! > Common comment, please do not limit LPSS drivers, including GPIO / pin > control, to be Appololake only. > They must be available for entire Intel Skylake family of SoCs > (basically all of them from Skylake, with maybe few exceptions).
I have certainly put some code in intel_common, but until we have a Skylake it is a pain to figure out what is common, etc. Clearly the GPIO code can be common, but it is very easy to move it when we have the next thing. I can move GPIO and LPSS over to common, for now. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
