Hi Wolfgang,
Sent: Wednesday, July 07, 2010 1:02 PM
To: Rupjyoti Sarmah
> - if (in_8((void *)(CONFIG_SYS_BCSR_BASE + 3)) &
CONFIG_SYS_BCSR3_PCIE)
> + if (bcsr_data->board_status & CONFIG_SYS_BCSR3_PCIE)
Please use I/O accessors to read the BCSR.
> - printf(", Rev. %X", in_8((void *)(CONFIG_SYS_BCSR_BASE + 0)));
> + printf(", Rev. %X", bcsr_data->cpld_rev);
Ditto. There are more changes like this - please fix all of them.
>>> Done.
> --- a/include/configs/canyonlands.h
> +++ b/include/configs/canyonlands.h
What is "ep460c"? We know 460EX (the CPU) and Canyonlands (the board).
>>> It is the Canyonlands board user manual ( ep460c from embedded
planet).
I changed this comment to make it more clear.
I am submitting [PATCH v2] with the changes.
Regards,
Rup
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
