Header files generally should not include header files just for a struct, since forward declarations work just as well and reduce overhead.
Add a warning for dm.h being included, since this has crept into U-Boot. Signed-off-by: Simon Glass <s...@chromium.org> dm: Avoid including dm.h in header files At present a small number of header files include the dm.h header file. The intent with driver model is for C files that use it to define dm.h themselves. This helps indicate that driver model is supported and also reduces the amount of code pointlessly included and relying on header guards. Ultimately (combined with the reduction in size of common.h) this should speed up U-Boot compilation. This series removes all uses of dm.h in header files and adds a warning to avert more such activity. END --- include/dm.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/dm.h b/include/dm.h index 2e1afda440..a1b84169e6 100644 --- a/include/dm.h +++ b/include/dm.h @@ -3,6 +3,10 @@ * Copyright (c) 2013 Google, Inc */ +#ifdef _DM_H_ +#warning "Suspect dm.h is included from a header file - please fix" +#endif + #ifndef _DM_H_ #define _DM_H_ -- 2.24.0.rc0.303.g954a862665-goog _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
