Hi Bin, On Mon, 28 Oct 2019 at 00:47, Bin Meng <bmeng...@gmail.com> wrote: > > Hi Simon, > > On Mon, Oct 21, 2019 at 11:33 AM Simon Glass <s...@chromium.org> wrote: > > > > When device-tree compilation fails it is sometimes tricky to see which > > line is broken, since the input file to dtc is a pre-processed version > > of the device tree. > > > > Add a line that points to the file that needs to be checked: > > > > Output is something like this: > > > > Error: arch/x86/dts/u-boot.dtsi:137.14-15 syntax error > > To me this already provides enough information for people to look at. > I don't think we need another line to duplicate the report. > > > FATAL ERROR: Unable to parse input tree > > Check /tmp/b/chromebook_coral/arch/x86/dts/.chromebook_coral.dtb.pre.tmp > > Another reason is that if the error does not happen in the dtsi file > but the main dts file, the line you added here is a duplicates of the > error message coming from the dtc. >
Part of the problem here is that the commit shows the un-preprocessed filename. I'll fix that and add a longer description. This commit has saved my bacon quite a few times and I think it has value. Hopefully you agree once you try it out, but if not, I'm going to drop it. > > for errors > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > --- > > > > Changes in v3: > > - Update example error message to better show the intended purpose > > > > Changes in v2: None > > > > scripts/Makefile.lib | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot