Hi Mike, On 7/4/2010 11:29 PM, Mike Frysinger wrote: > The DM9000 in/out helper functions were casting the register address when > it was accessing things directly (pre commit a45dde2293c816138e53c). But > when it was changed to using the in/out helpers, those casts were dropped > because those functions don't take pointers. Even more recently, those > functions were then changed to use the read/write helpers, but the casts > were not re-added. This is necessary because the read/write helpers do > take pointers. Otherwise we get a lot of warnings like: > dm9000x.c: In function 'dm9000_inblk_8bit': > dm9000x.c:172: warning: passing argument 1 of 'readb' > makes pointer from integer without a cast > > Signed-off-by: Mike Frysinger<vap...@gentoo.org> > --- > drivers/net/dm9000x.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c > index 137e41f..709f67a 100644 > --- a/drivers/net/dm9000x.c > +++ b/drivers/net/dm9000x.c > @@ -117,12 +117,12 @@ static void DM9000_iow(int reg, u8 value); > > /* DM9000 network board routine ---------------------------- */ > > -#define DM9000_outb(d,r) writeb(d, r) > -#define DM9000_outw(d,r) writew(d, r) > -#define DM9000_outl(d,r) writel(d, r) > -#define DM9000_inb(r) readb(r) > -#define DM9000_inw(r) readw(r) > -#define DM9000_inl(r) readl(r) > +#define DM9000_outb(d,r) writeb(d, (volatile u8 *)(r)) > +#define DM9000_outw(d,r) writew(d, (volatile u16 *)(r)) > +#define DM9000_outl(d,r) writel(d, (volatile u32 *)(r)) > +#define DM9000_inb(r) readb((volatile u8 *)(r)) > +#define DM9000_inw(r) readw((volatile u16 *)(r)) > +#define DM9000_inl(r) readl((volatile u32 *)(r)) > > #ifdef CONFIG_DM9000_DEBUG > static void Applied to net repo.
thanks, Ben _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
