Hi Kever, On Mon, 2019-11-18 at 11:05 +0800, Kever Yang wrote: > Hi Kurt, > > On 2019/11/14 上午2:44, Kurt Miller wrote: > > > > On Tue, 2019-09-17 at 12:02 -0400, Kurt Miller wrote: > > > > > > On Tue, 2019-09-17 at 10:57 +0800, Kever Yang wrote: > > > > > > > > Hi Kurt, > > > > > > > > Could you try with below update: > > > > > > > > > > > > diff --git a/arch/arm/dts/rk3399-sdram-lpddr4-100.dtsi > > > > b/arch/arm/dts/rk3399-sdram-lpddr4-100.dtsi > > > > index 4a4414a960..dc9db047cb 100644 > > > > --- a/arch/arm/dts/rk3399-sdram-lpddr4-100.dtsi > > > > +++ b/arch/arm/dts/rk3399-sdram-lpddr4-100.dtsi > > > > @@ -13,8 +13,8 @@ > > > > 0x2 > > > > 0x1 > > > > 0x0 > > > > - 0xf > > > > - 0xf > > > > + 0x10 > > > > + 0x10 > > > > 1 > > > > 0x80241d22 > > > > 0x15050f08 > > > > @@ -28,8 +28,8 @@ > > > > 0x2 > > > > 0x1 > > > > 0x0 > > > > - 0xf > > > > - 0xf > > > > + 0x10 > > > > + 0x10 > > > > 1 > > > > 0x80241d22 > > > > 0x15050f08 > > > > > > > > Thanks, > > > > - Kever > > > Hi Kever, > > > > > > Yes, that diff does correct the memory size detection > > > for my board: > > > > > > U-Boot TPL 2019.10-rc3-00332-ga314ec1bfd-dirty (Sep 17 2019 - 11:55:26) > > > con reg > > > cru , cic , grf , sgrf , pmucru , pmu > > > Starting SDRAM initialization... > > > sdram_init: data trained for rank 1, ch 0 > > > sdram_init: data trained for rank 1, ch 1 > > > Channel 0: LPDDR4, 50MHz > > > BW=32 Col=10 Bk=8 CS0 Row=16 CS=1 Die BW=16 Size=2048MB > > > Channel 1: LPDDR4, 50MHz > > > BW=32 Col=10 Bk=8 CS0 Row=16 CS=1 Die BW=16 Size=2048MB > > > 256B stride > > > lpddr4_set_ctl: channel 0 training pass > > > lpddr4_set_ctl: channel 1 training pass > > > lpddr4_set_rate: change freq to 400 mhz 0, 1 > > > lpddr4_set_ctl: channel 0 training pass > > > lpddr4_set_ctl: channel 1 training pass > > > lpddr4_set_rate: change freq to 800 mhz 1, 0 > > > Finish SDRAM initialization... > > > Trying to boot from BOOTROM > > > Returning to boot ROM... > > Hi Kever, > > > > Following up on this issue. I retested 2020.01-rc2 to see if > > memory size detection has been fixed yet. Without your diff above > > applied, 2020.01-rc2 still detects 2G memory instead of 4G: > > Could you try with latest u-boot-rockchip? > > https://gitlab.denx.de/u-boot/custodians/u-boot-rockchip.git >
The latest u-boot-rockchip does detect the correct memory size. I'll keep an eye out for the next rockchip pull to master occurs. Thank you, -Kurt U-Boot TPL 2020.01-rc2-04834-g59b01eb7a1-dirty (Nov 18 2019 - 10:34:14) con reg ffa80000 ffa80800 ffa82000 ffa84000 ffa88000 ffa88800 ffa8a000 ffa8c000 cru ff760000, cic ff620000, grf ff320000, sgrf ff330000, pmucru ff750000, pmu ff310000 Starting SDRAM initialization... sdram_init: data trained for rank 1, ch 0 sdram_init: data trained for rank 1, ch 1 Channel 0: LPDDR4, 50MHz BW=32 Col=10 Bk=8 CS0 Row=16/15 CS=1 Die BW=16 Size=2048MB Channel 1: LPDDR4, 50MHz BW=32 Col=10 Bk=8 CS0 Row=16/15 CS=1 Die BW=16 Size=2048MB 256B stride 256B stride lpddr4_set_ctl: channel 0 training pass lpddr4_set_ctl: channel 1 training pass lpddr4_set_rate: change freq to 400000000 mhz 0, 1 lpddr4_set_ctl: channel 0 training pass lpddr4_set_ctl: channel 1 training pass lpddr4_set_rate: change freq to 800000000 mhz 1, 0 Finish SDRAM initialization... Trying to boot from BOOTROM Returning to boot ROM... U-Boot SPL 2020.01-rc2-04834-g59b01eb7a1-dirty (Nov 18 2019 - 10:34:14 -0500) Trying to boot from MMC1 NOTICE: BL31: v2.2(debug):2.2 NOTICE: BL31: Built : 10:33:33, Nov 18 2019 INFO: GICv3 with legacy support detected. ARM GICv3 driver initialized in EL3 INFO: plat_rockchip_pmu_init(1605): pd status 3e INFO: BL31: Initializing runtime services INFO: BL31: cortex_a53: CPU workaround for 855873 was applied INFO: BL31: Preparing for EL3 exit to normal world INFO: Entry point address = 0x200000 INFO: SPSR = 0x3c9 U-Boot 2020.01-rc2-04834-g59b01eb7a1-dirty (Nov 18 2019 - 10:34:14 -0500) Model: Pine64 RockPro64 DRAM: rk3399_dmc_probe: pmugrf = 00000000ff320000 3.9 GiB PMIC: RK808 MMC: dwmmc@fe320000: 1, sdhci@fe330000: 0 Loading Environment from MMC... Card did not respond to voltage select! *** Warning - No block device, using default environment In: serial@ff1a0000 Out: serial@ff1a0000 Err: serial@ff1a0000 Model: Pine64 RockPro64 rockchip_dnl_key_pressed: adc_channel_single_shot fail! Net: eth0: ethernet@fe300000 Hit any key to stop autoboot: 0 Card did not respond to voltage select! switch to partitions #0, OK mmc1 is current device Scanning mmc 1:1... Found EFI removable media binary efi/boot/bootaa64.efi libfdt fdt_check_header(): FDT_ERR_BADMAGIC Scanning disk dw...@fe320000.blk... ** Unrecognized filesystem type ** Card did not respond to voltage select! Scanning disk sd...@fe330000.blk... Disk sd...@fe330000.blk not ready Found 3 disks BootOrder not defined EFI boot manager: Cannot load any image 161090 bytes read in 16 ms (9.6 MiB/s) libfdt fdt_check_header(): FDT_ERR_BADMAGIC disks: sd0* >> OpenBSD/arm64 BOOTAA64 0.19 boot> booting sd0a:/bsd: 7480340+1599872+539984+848776 [621522+109+869160+526938]=0xd3fe68 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot