On 11/19/19 4:27 AM, Ley Foon Tan wrote: > On Thu, Nov 14, 2019 at 3:46 AM Simon Goldschmidt > <simon.k.r.goldschm...@gmail.com> wrote: >> >> Am 08.11.2019 um 05:11 schrieb Ley Foon Tan: >>> Add device tree files for Agilex SoC platform. >>> >>> Based on Linux Commit ID 4b36daf9ada30. >> >> Based on? Why is this not a copy of the Linux devicetree files? The >> single difference should be in *-u-boot.dtsi. Being like this, I don't >> know what good it is to add the Linux commit ID if the files are >> obviously different... :-( > Some dts properties are missing in Linux dts. E.g: > - The clock dts information is not upstreamed in Linux yet. > - CCU node is not in Linux dts (Linux doesn't need to initialize CCU) > - Compatible string for rstmgr is different in Linux and Uboot. > > So, there are some differences in Linux vs Uboot dts/dtsi. > I can remove Linux commit ID in commit message if it is confusing.
Or maybe you can pull the extras into socfpga_agilex-u-boot.dtsi and keep the socfpga_agilex.dtsi as it is from Linux ? _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot