Hi Bin, On Mon, 25 Nov 2019 at 22:13, Bin Meng <bmeng...@gmail.com> wrote: > > Hi Simon, > > On Mon, Nov 25, 2019 at 12:11 PM Simon Glass <s...@chromium.org> wrote: > > > > Allow this driver to set up an IO address in SPL using an 'early-regs' > > property. This allows SPL to use the I2C driver without having to enable > > the full PCI stack. > > > > Also split out ofdata_to_platdata in designware driver since this is more > > correct, and more convenient for the new logic. > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > --- > > > > Changes in v5: None > > Changes in v4: > > - Add new patch to allow designware I2C driver to work in SPL > > > > Changes in v3: None > > Changes in v2: None > > > > drivers/i2c/designware_i2c_pci.c | 46 +++++++++++++++++++++++++++++--- > > 1 file changed, 43 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/i2c/designware_i2c_pci.c > > b/drivers/i2c/designware_i2c_pci.c > > index 8d6bb37f5c..2bf90eaa4b 100644 > > --- a/drivers/i2c/designware_i2c_pci.c > > +++ b/drivers/i2c/designware_i2c_pci.c > > @@ -7,6 +7,7 @@ > > > > #include <common.h> > > #include <dm.h> > > +#include <spl.h> > > #include "designware_i2c.h" > > > > /* BayTrail HCNT/LCNT/SDA hold time */ > > @@ -18,17 +19,49 @@ static struct dw_scl_sda_cfg byt_config = { > > .sda_hold = 0x6, > > }; > > > > -static int designware_i2c_pci_probe(struct udevice *dev) > > +/* Have a weak function for now - possibly should be a new uclass */ > > +__weak void lpss_reset_release(void *regs); > > This function is not called in this driver. Maybe this should belong > to another commit?
OK I'll move it to where the changes are made for APL. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot