Hi Stephen, On Tue, 7 Jan 2020 at 11:18, Stephen Warren <swar...@wwwdotorg.org> wrote: > > From: Stephen Warren <swar...@nvidia.com> > > All Tegra chips except Tegra186 have a tegraNNN-u-boot.dtsi. Duplicate > Tegra210's copy of this file for Tegra186. This ensures that a /binman node > exists in U-Boot's control DT. Subsequent to 3c10dc95bdd0 ("binman: Add a > library to access binman entries") this appears to be required. I haven't > really investigated why all this is necessary or how it works, but simply > observed the boot failure listed below, bisected it, noticed the > inconsistency in DT files, and found that fixing it resolved the boot > issue.
If CONFIG_BINMAN is enabled, binman_init() is called and expects to find a /binman node. > > U-Boot 2020.01-rc4-00256-g3c10dc95bdd0 (Jan 07 2020 - 10:25:00 -0700) > > SoC: tegra186 > Model: NVIDIA P2771-0000-500 > Board: NVIDIA P2771-0000 > DRAM: 7.8 GiB > initcall sequence 00000000fffb7858 failed at call 00000000800955a8 > (err=-22) > ### ERROR ### Please RESET the board ### > > Fixes: 3c10dc95bdd0 ("binman: Add a library to access binman entries") > Fixes: f2faffecb016 ("binman: tegra: Convert to use binman") > Signed-off-by: Stephen Warren <swar...@nvidia.com> > --- > arch/arm/dts/tegra186-u-boot.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > create mode 100644 arch/arm/dts/tegra186-u-boot.dtsi Reviewed-by: Simon Glass <s...@chromium.org>