Hi Michal, On Tue, Jan 14, 2020 at 5:49 AM Michal Simek <mon...@monstr.eu> wrote: > > +Luis > > čt 9. 1. 2020 v 14:00 odesílatel Milan Obuch <u-b...@dino.sk> napsal: > > > > Zybo Z7 board has two push button connected to MIO pins 50 and 51, > > connecting them to Vcc1V8 when pressed, and pulldown resistors > > connected to ground. These two pins are initialised with internal > > pullup resistors enabled, so they are reported as 1 all the time with > > no change when pressed. > > > > @@ -219,8 +219,8 @@ > > EMIT_MASKWRITE(0xF80007BC, 0x00003F01U, 0x00001201U), > > EMIT_MASKWRITE(0xF80007C0, 0x00003FFFU, 0x000012E0U), > > EMIT_MASKWRITE(0xF80007C4, 0x00003FFFU, 0x000012E1U), > > - EMIT_MASKWRITE(0xF80007C8, 0x00003FFFU, 0x00001200U), > > - EMIT_MASKWRITE(0xF80007CC, 0x00003FFFU, 0x00001200U), > > + EMIT_MASKWRITE(0xF80007C8, 0x00003FFFU, 0x00000200U), > > + EMIT_MASKWRITE(0xF80007CC, 0x00003FFFU, 0x00000200U), > > EMIT_MASKWRITE(0xF80007D0, 0x00003FFFU, 0x00001280U), > > EMIT_MASKWRITE(0xF80007D4, 0x00003FFFU, 0x00001280U), > > EMIT_MASKWRITE(0xF8000830, 0x003F003FU, 0x002F0037U), > > Luis: Can you please comment? > > I have not a problem with this patch but please send it as regular patch. > git format-patch and then git send-email or use u-boot patman tools > for sending it.
I successfully tested the patch on a Zybo Z7-20 board. The push buttons are now handled correctly. Tested with the command "gpio status -a" When the push buttons are not pressed: > gpio@e000a00050: input: 0 [ ] > gpio@e000a00051: input: 0 [ ] When the push buttons are pressed: > gpio@e000a00050: input: 1 [ ] > gpio@e000a00051: input: 1 [ ] Once the commit is in shape to be merged, feel free to add my Tested-by tag. Tested-by: Luis Araneda <luaran...@gmail.com> Please ping me if the author does not want to send a proper git patch so I can send it instead. I don't want this work to be lost. Regards, Luis Araneda.
