Re: [PATCH v2 1/4] board_f.c: Insure gd->new_bootstage alignment

[Stephen Warren]

On 1/22/20 6:52 AM, Patrick Delaunay wrote:

From: Patrice Chotard <patrice.chot...@st.com>

In reserve_bootstage(), in case size is odd, gd->new_bootstage
is not aligned. In bootstage_relocate(), the platform hangs when
getting access to data->record[i].name.
To avoid this issue, make gd->new_bootstage 16 byte aligned.

To insure that new_bootstage is 16 byte aligned (at least needed for
x86_64 and ARMv8) and new_bootstage starts down to get enough space,
ALIGN_DOWN macro is used.

diff --git a/common/board_f.c b/common/board_f.c
index d66afb37ca..e21f533634 100644
--- a/common/board_f.c
+++ b/common/board_f.c
@@ -562,6 +562,11 @@ static int reserve_bootstage(void)
        int size = bootstage_get_size();

gd->start_addr_sp -= size;

+       /*
+        * Insure that start_addr_sp is aligned down to reserve enough

Nit: Ensure not insure (a pet peeve of mine!)

+        * space for new_bootstage
+        */
+       gd->start_addr_sp = ALIGN_DOWN(gd->start_addr_sp, 16);
        gd->new_bootstage = map_sysmem(gd->start_addr_sp, size);
        debug("Reserving %#x Bytes for bootstage at: %08lx\n", size,
              gd->start_addr_sp);