On 1/27/20 9:53 PM, Peng Fan wrote: >> Subject: [PATCH 0/3] Support SDMA mode on RPI4 target - 32bit >> >> RPI4's SDHCI controller is supported SDMA mode. (Checked on kernel side) >> But It doesn't use on u-boot side. Then it's too slow about read/write >> performance. >> This patchset is supported SDMA mode on RPI4 target(32bit). >> - I didn't test on RPI4 64bit. >> >> Read/write time about 8MB file >> Before >> - Read : 1.472 seconds >> - Write : 4.690 seconds >> After >> - Read : 0.359 seconds >> - Write : 0.574 seconds > > For patch 2/3, I prefer to use printf, not debug. Other than that, > For the whole patchset,
Well, i know what you want. but when use printf, it will be displayed ugly log relevant to mmcnr@73e0000. mmcnr@73e0000 is used for WiFi on RPI4 target. So i changed from printf to debug. - Because RPI4 is using dt that passed by firmware. U-Boot 2019.10-00002-g4746c115cc-dirty (Jan 28 2020 - 13:57:03 +0900) DRAM: 3.9 GiB RPI 4 Model B (0xc03111) MMC: sdhci_setup_cfg: Your controller doesn't support SDMA!! emmc2@7e340000: 0, mmcnr@7e300000: 1 But if you're ok about above, i will resend the patches with your reviewed-tag. And I will send patch about Host controller information. mmcinfo is displayed many informations. but it doesn't know which mode is using. e.g) SDMA, ADMA, PIO, DMA mode, etc. Those have dependent with Host controller. If it's showed with any command, it's helpful to use. how about? Best Regards, Jaehoon Chung > > Reviewed-by: Peng Fan <peng....@nxp.com> > >> >> This patch is based on my RFC's patches. >> >> Jaehoon Chung (3): >> mmc: sdhci: use phys2bus macro when dma address is accessed >> mmc: sdhci: not return error when SDMA is not supported >> configs: rpi_4_32b_defconfig: enable SDHCI_SDMA config >> >> configs/rpi_4_32b_defconfig | 1 + >> drivers/mmc/sdhci.c | 16 +++++++++------- >> 2 files changed, 10 insertions(+), 7 deletions(-) >> >> -- >> 2.25.0 >
