Thanks for following-up,

On 08/03/2010 12:30 AM, Xiangfu Liu wrote:
> From: Xiangfu Liu <xian...@sharism.cc>
> 
> Hi Wolfgang

No greetings in the longlog, please.  Such comments, supplements are
to go below the three-dashes (---):

>>From the document, if set all arguments in "OUTPUT_FORMAT"
> to "tradbigmips", then even add "-EL" to gcc we still get 
> EB format.
> 
> Signed-off-by: Xiangfu Liu <xian...@openmobilefree.net>
> ---

(Here...)

>  board/dbau1x00/u-boot.lds    |    2 +-
>  board/gth2/u-boot.lds        |    2 +-
>  board/incaip/u-boot.lds      |    2 +-
>  board/pb1x00/u-boot.lds      |    2 +-
>  board/purple/u-boot.lds      |    2 +-
>  board/qemu-mips/u-boot.lds   |    2 +-
>  examples/standalone/mips.lds |    2 +-
>  7 files changed, 7 insertions(+), 7 deletions(-)
[snip]
> diff --git a/board/pb1x00/u-boot.lds b/board/pb1x00/u-boot.lds
> index 9a6cd1b..3c4fbe3 100644
> --- a/board/pb1x00/u-boot.lds
> +++ b/board/pb1x00/u-boot.lds
> @@ -24,7 +24,7 @@
>  /*
>  OUTPUT_FORMAT("elf32-bigmips", "elf32-bigmips", "elf32-bigmips")
>  */
> -OUTPUT_FORMAT("elf32-tradbigmips", "elf32-tradbigmips", "elf32-tradbigmips")
> +OUTPUT_FORMAT("elf32-tradbigmips", "elf32-tradbigmips", 
> "elf32-tradlittlemips")
>  OUTPUT_ARCH(mips)
>  ENTRY(_start)
>  SECTIONS

According to MAKEALL script, pb1000_config is only used in Little-
endian, so its default endian should be set to LE as well.  I too
missed this point in my previous patch.

With fixing above nits, feel free to add:

Acked-by: Shinya Kuribayashi <skuri...@pobox.com>

Wolfgang: Could you take care of this patch (hopefully revised one)
directly into your master. The fix is obvious.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to