Hi Bin > Hi Rick, > > When going through all patches in the RISC-V queue, I found this old > patch was not applied. Is it still needed?
It is unnecessary now. > > Anyway, see my review comments below. Thanks for your review! Thanks Rick > > On Mon, Oct 8, 2018 at 1:43 PM Andes <ub...@andestech.com> wrote: > > > > From: Rick Chen <r...@andestech.com> > > > > Add to print board and bit information message. > > nits: please remove the ending period in the commit title > > > > > Signed-off-by: Rick Chen <r...@andestech.com> > > Cc: Greentime Hu <greent...@andestech.com> > > --- > > board/AndesTech/ax25-ae350/ax25-ae350.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/board/AndesTech/ax25-ae350/ax25-ae350.c > > b/board/AndesTech/ax25-ae350/ax25-ae350.c > > index 5f4ca0f..61ca10b 100644 > > --- a/board/AndesTech/ax25-ae350/ax25-ae350.c > > +++ b/board/AndesTech/ax25-ae350/ax25-ae350.c > > @@ -20,6 +20,7 @@ DECLARE_GLOBAL_DATA_PTR; > > > > int board_init(void) > > { > > + printf("Board: %s (%d)\n" , CONFIG_SYS_BOARD, __riscv_xlen); > > nits: remove the space after \n", and one space before CONFIG_SYS_BOARD. > > > gd->bd->bi_boot_params = PHYS_SDRAM_0 + 0x400; > > > > return 0; > > -- > > Regards, > Bin