On Mon, 10 Feb 2020 09:40:50 -0500 Tom Rini <tr...@konsulko.com> wrote: > That said, the "bring in PXE" part of DISTRO_DEFAULTS predates sysboot > being pulled out of the PXE code, where it was historically > introduced. I would like to see a patch to change this part, > stand-alone and CC'ing the distribution folks that might have > something to say about this. I know there are use-cases for it, but > I don't know how critical they are to be everywhere by default vs > opt-in. Thanks all! I've done the patch, but I've not sent it yet.
With it, if board are using things like func(PXE, pxe, na) in BOOT_TARGET_DEVICES, it will breaks the compilation, and we would have an error that looks like that: > In file included from include/configs/tbs2910.h:19, > from include/config.h:5, > from include/common.h:16, > from env/common.c:10: > include/config_distro_bootcmd.h:398:2: error: expected '}' before > 'BOOT_TARGET_DEVICES_references_PXE_without_CONFIG_CMD_DHCP_or_PXE' > 398 | > BOOT_TARGET_DEVICES_references_PXE_without_CONFIG_CMD_DHCP_or_PXE Should I still send the patch as-is by mentioning that issue somehow, in order to start a discussion on the topic? Or would I need to do more in depth changes before sending the patch? In the later case I would also need to find some time to do that, so it might not be done that fast. Denis.
pgptxkGO6brFq.pgp
Description: OpenPGP digital signature