On Mon, Jan 20, 2020 at 7:06 PM Peter Robinson <pbrobin...@gmail.com> wrote: > > On Mon, 20 Jan 2020, 10:08 Kever Yang, <kever.y...@rock-chips.com> wrote: > > > Hi Peter, > > > > On 2020/1/20 下午5:22, Peter Robinson wrote: > > > On Mon, Jan 13, 2020 at 7:03 AM Kever Yang <kever.y...@rock-chips.com> > > wrote: > > >> Hi Peter, > > >> > > >> On 2020/1/8 上午11:56, Peter Robinson wrote: > > >>> Put the target entries for rk3399 devices in alphabetical order. > > >>> > > >>> Signed-off-by: Peter Robinson <pbrobin...@gmail.com> > > >> Reviewed-by: Kever Yang <kever.y...@rock-chips.com> > > > Any reason this didn't make the latest rockchip MR? > > > > This patch break the build for rk3399 boards other than chromebook_bob, > > > > and I have to leave it until other boards add CONFIG_TARGET_* to pass > > the build. > > > > How would it do that by simply reordering a kconfig file? I've tested it > with at least building evm, rock960, rockpro64 and firefly 3399 builds with > out issues.
AFAICT if the defconfig has no preferred setting, then the first entry is used. The targets you tested likely all had a preferred setting, but other ones such as the NanoPi M4 did not, and was counting on the EVB target being the default. ChenYu