RE: [PATCH v4 12/21] arch: arm: socfpga: Enable driver model for misc drivers.

[Ang, Chee Hong]

> Am 09.03.2020 um 10:07 schrieb chee.hong....@intel.com:
> > From: Chee Hong Ang <chee.hong....@intel.com>
> >
> > Enable this misc driver model for 'altera_sysmgr' driver for socfpga
> > platforms.
> >
> > Signed-off-by: Chee Hong Ang <chee.hong....@intel.com>
> > ---
> >  arch/arm/Kconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index
> > 8d9f7fc..4ee8ae0 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -937,9 +937,11 @@ config ARCH_SOCFPGA
> >     select DM
> >     select DM_SERIAL
> >     select ENABLE_ARM_SOC_BOOT0_HOOK if TARGET_SOCFPGA_GEN5 ||
> > TARGET_SOCFPGA_ARRIA10
> > +   select MISC
> 
> Please don't 'select' this. You prevent building smaller configs that don't 
> need it.
> Please use 'imply' instead.
OK.
> 
> >     select OF_CONTROL
> >     select SPL_DM_RESET if DM_RESET
> >     select SPL_DM_SERIAL
> > +   select SPL_DRIVERS_MISC_SUPPORT
> 
> Especially this one makes gen5 SPL uneccessary large.
I will use 'imply' for this as well.
> 
> Regards,
> Simon
> 
> >     select SPL_LIBCOMMON_SUPPORT
> >     select SPL_LIBGENERIC_SUPPORT
> >     select SPL_NAND_SUPPORT if SPL_NAND_DENALI
> >