Hi Tom, On Mon, 9 Mar 2020 at 11:55, Tom Rini <tr...@konsulko.com> wrote: > > On Fri, Mar 06, 2020 at 08:07:14PM -0700, Simon Glass wrote: > > > At present there are several things in the gitlab script which work around > > limitations in buildman. With a few small feature additions these can be > > removed. > > > > This series adds some new features to buildman and simplifies the script: > > - Option to run a single build in a specified output directory > > - Allow ignoring warnings > > - Removes a restriction on the build output directory > > > > It also > > - moves test.py over to use buildman for the --build option > > - makes one change to azure since the same approach should be possible there > > - fixes a few minor problems noticed in main and sandbox docs > > One general comment is that while it's clear from this series that > you're focusing on test.py invocation most of the time, a lot of the > commit messages aren't clear that you're changing the > buildman_and_testpy_template stanza.
I'm not sure what you are looking for there. Do you want the commit message to mention which part of the gitlab file is being changed? > > Also, while you're keeping Azure in sync (as it's largely based on the > GitLab logic), Travis is being left out. But the GitLab logic is based > on the Travis logic and as much as I dislike Travis for being slow and > having network induced failures, it's still a valid and supported CI > flow that we can't drop, so please keep it in sync with these > improvements, thanks! OK. Regards, Simon