Hi Tom,
On 3/17/20 7:51 PM, Sean Anderson wrote:
On 3/17/20 10:09 AM, Niel Fourie wrote:
Renamed dm "drivers" subcommand to "compat" (as it listed
compatibility strings) and prevent it from segfaulting when
drivers have no of_match populated.
Added a new "drivers" subcommand to dump a list of all known DM
drivers and for each, their uclass id, uclass driver and names of
attached devices.
Added a new "static" subcommand to dump a list of DM drivers with
statically defined platform data.
Signed-off-by: Niel Fourie <lu...@denx.de>
CC: Simon Glass <s...@chromium.org>
---
cmd/dm.c | 24 ++++++++++++++++--
drivers/core/dump.c | 60 ++++++++++++++++++++++++++++++++++++++++++++-
include/dm/util.h | 6 +++++
3 files changed, 87 insertions(+), 3 deletions(-)
<snip>
In drivers/core/dump.c:
-void dm_dump_drivers(void)
+void dm_dump_driver_compat(void)
{
struct driver *d = ll_entry_start(struct driver, driver);
const int n_ents = ll_entry_count(struct driver, driver);
@@ -107,6 +107,9 @@ void dm_dump_drivers(void)
puts("Driver Compatible\n");
puts("--------------------------------\n");
for (entry = d; entry < d + n_ents; entry++) {
+ if (!entry->of_match) {
+ continue;
+ }
This should have been fixed in version 2 of the patch [1].
[1] https://patchwork.ozlabs.org/patch/1234460/
Should I rebase my series on the version 2 of the above patch, or should
I simply include that change in my series instead? Thanks in advance!
Best regards,
Niel Fourie
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-21 Fax: +49-8142-66989-80 Email: lu...@denx.de
