On Fri, Mar 27, 2020 at 10:19:05AM +0800, Bin Meng wrote:
> Hi Tom,
> 
> On Fri, Mar 27, 2020 at 10:01 AM Tom Rini <tr...@konsulko.com> wrote:
> >
> > On Fri, Mar 27, 2020 at 09:51:03AM +0800, Bin Meng wrote:
> > > Hi Tom,
> > >
> > > On Fri, Mar 27, 2020 at 12:10 AM Tom Rini <tr...@konsulko.com> wrote:
> > > >
> > > > On Thu, Mar 26, 2020 at 09:05:21AM -0700, Bin Meng wrote:
> > > >
> > > > > As of today there is no pre-built UEFI GRUB image for RISC-V 32/64
> > > > > available on the internet, and with travis-ci we don't build GRUB
> > > > > images like we do for azure and gitlab.
> > > > >
> > > > > Remove qemu-riscv64 testing temporarily.
> > > > >
> > > > > Signed-off-by: Bin Meng <bmeng...@gmail.com>
> > > > > ---
> > > > >
> > > > >  .travis.yml | 7 -------
> > > > >  1 file changed, 7 deletions(-)
> > > > >
> > > > > diff --git a/.travis.yml b/.travis.yml
> > > > > index c59bd77..55b94cf 100644
> > > > > --- a/.travis.yml
> > > > > +++ b/.travis.yml
> > > > > @@ -481,13 +481,6 @@ matrix:
> > > > >            QEMU_TARGET="ppc-softmmu"
> > > > >            BUILDMAN="^qemu-ppce500$"
> > > > >            TOOLCHAIN="powerpc"
> > > > > -    - name: "test/py qemu-riscv64"
> > > > > -      env:
> > > > > -        - TEST_PY_BD="qemu-riscv64"
> > > > > -          TEST_PY_TEST_SPEC="not sleep"
> > > > > -          QEMU_TARGET="riscv64-softmmu"
> > > > > -          BUILDMAN="^qemu-riscv64$"
> > > > > -          TOOLCHAIN="riscv"
> > > > >      - name: "test/py qemu-x86"
> > > > >        env:
> > > > >          - TEST_PY_BD="qemu-x86"
> > > >
> > > > But why are we removing this?  We run all of the rest of the test suites
> > > > and I don't think this one test adds noticeably to the overall Travis
> > > > time.  Thanks!
> > >
> > > The reason was mentioned in the commit message.
> > >
> > > As of today there is no pre-built UEFI GRUB image for RISC-V 32/64
> > > available on the internet, and with travis-ci we don't build GRUB
> > > images like we do for azure and gitlab.
> > >
> > > Do you want to build GRUB image in travis, like what's done in the
> > > docker image used for azure/gitlab?
> >
> > But this isn't just for testing GRUB via UEFI, it runs our test/py suite
> > too.  And that's worth doing, right?
> 
> Yes, and this testing is covered in azure/gitlab. The issue is that
> whether we need build GRUB in travis. If yes, I can update the travis
> scripts to sync with azure/gitlab.

So you're trying to keep them all consistent in terms of what's covered.
I'm not sure that's viable and we have other cases where I believe some
tests aren't run in Travis but only gitlab such as the filesystem tests.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to