Quoting Jagan Teki (2020-03-28 15:32:46) > On Tue, Mar 3, 2020 at 8:37 PM Jonas Smedegaard <d...@jones.dk> wrote: > > > > commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to > > Kconfig") intended to support CONFIG_PREBOOT, but > > include/configs/sunxi-common.h hardcodes preboot as part of internally > > defined CONSOLE_STDIN_SETTINGS, silently ignoring any board-specific > > CONFIG_PREBOOT. > > > > This commit moves sunxi-specific CONFIG_PREBOOT to Kconfig, > > which supports board-specific override. > > > > Tested-by: Jonas Smedegaard <d...@jones.dk> > > Signed-off-by: Jonas Smedegaard <d...@jones.dk> > > Series-Cc: Jagan Teki <ja...@amarulasolutions.com> > > Series-Cc: Lukasz Majewski <lu...@denx.de> > > Series-Cc: Andre Przywara <andre.przyw...@arm.com> > > > > --- > > > > > > Changes in v3: > > - move default setting to KConfig, thanks to Andre Przywara and Lukasz > > Majewski > > > > Changes in v2: > > - Rephrase commit message to clarify relationship with KConfig entries > > > > --- > > arch/arm/mach-sunxi/Kconfig | 3 +++ > > include/configs/sunxi-common.h | 1 - > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > > index 3a3b673430..9f16d903a0 100644 > > --- a/arch/arm/mach-sunxi/Kconfig > > +++ b/arch/arm/mach-sunxi/Kconfig > > @@ -48,6 +48,9 @@ config DRAM_SUN50I_H6 > > Select this dram controller driver for some sun50i platforms, > > like H6. > > > > +config PREBOOT > > + default "usb start" if USB_KEYBOARD > > + > > This is already available in common/Kconfig better select there with > proper depends.
Makes sense, I will make another revision... Thanks! - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature