> From: Jagan Teki <ja...@amarulasolutions.com> > Cc: su...@amarulasolutions.com, u-boot@lists.denx.de, > linux-rockc...@lists.infradead.org, > linux-amar...@amarulasolutions.com, > Jagan Teki <ja...@amarulasolutions.com> > Date: Mon, 30 Mar 2020 23:46:10 +0530 > Content-Type: text/plain; charset=UTF-8 > > Linux supporting assigned-clocks for VOP on rk3399 by assuming > U-Boot not initializing it on this linux commit: > > commit <617f4472bdd3> ("arm64: dts: rockchip: init rk3399 vop clock rates") > > There is no specific need to initialize these assigned clock > in U-Boot as video drivers still work with default aclk and > hclk values. So, these clocks are simply not supported by rk3399 > clock driver. > > But, during stdio probe of vidconsole, the device probe > will try to check whether the assigned clocks on that video > console node is initialized or not? and return error if not. > > So, delete these property via -u-boot dtsi as there is > no specific need in U-Boot.
Deleting these properties isn't very helpful as it means the U-Boot device tree can no longer be used by the kernel. Isn't it a better idea to implement these clocks as stubs in the u-boot clock driver? > Signed-off-by: Jagan Teki <ja...@amarulasolutions.com> > --- > Changes for v2: > - none > > arch/arm/dts/rk3399-u-boot.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/dts/rk3399-u-boot.dtsi b/arch/arm/dts/rk3399-u-boot.dtsi > index 8b857ccfc7..b846f9cde7 100644 > --- a/arch/arm/dts/rk3399-u-boot.dtsi > +++ b/arch/arm/dts/rk3399-u-boot.dtsi > @@ -99,9 +99,13 @@ > }; > > &vopb { > + /delete-property/ assigned-clocks; > + /delete-property/ assigned-clock-rates; > u-boot,dm-pre-reloc; > }; > > &vopl { > + /delete-property/ assigned-clocks; > + /delete-property/ assigned-clock-rates; > u-boot,dm-pre-reloc; > }; > -- > 2.17.1 > >