On 31/03/20 5:21 am, Alex Nemirovsky wrote:
> Add SPI NAND and NOR support for Cortina Access
> Presidio Engineering Board
>
> Signed-off-by: Alex Nemirovsky <alex.nemirov...@cortina-access.com>
> CC: Jagan Teki <ja...@amarulasolutions.com>
> CC: Vignesh R <vigne...@ti.com>
> ---
>
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> arch/arm/dts/ca-presidio-engboard.dts | 8 ++--
> board/cortina/presidio-asic/presidio.c | 16 ++++++-
> configs/cortina_presidio-asic-spi-nand_defconfig | 48 +++++++++++++++++++
> configs/cortina_presidio-asic-spi-nor_defconfig | 59
> ++++++++++++++++++++++++
> 4 files changed, 125 insertions(+), 6 deletions(-)
> create mode 100644 configs/cortina_presidio-asic-spi-nand_defconfig
> create mode 100644 configs/cortina_presidio-asic-spi-nor_defconfig
>
> diff --git a/arch/arm/dts/ca-presidio-engboard.dts
> b/arch/arm/dts/ca-presidio-engboard.dts
> index eef433e..50e1b29 100644
> --- a/arch/arm/dts/ca-presidio-engboard.dts
> +++ b/arch/arm/dts/ca-presidio-engboard.dts
> @@ -53,15 +53,13 @@
> };
>
> sflash: sflash-controller@f4324000 {
> - #address-cells = <2>;
> - #size-cells = <1>;
> compatible = "cortina,ca-sflash";
> reg = <0x0 0xf4324000 0x50>;
> reg-names = "sflash-regs";
> flash@0 {
> - compatible = "jedec,spi-nor";
> - spi-rx-bus-width = <1>;
> - spi-max-frequency = <108000000>;
> + compatible = "spi-nand", "jedec,spi-nor";
This does not make sense. Flash cannot be NAND and NOR at the same time?
compatible should be set to either one of them but not both
> + spi-rx-bus-width = <4>;
> + spi-tx-bus-width = <4>;
> };
> };
