On 05/04/2020 07:59, Manivannan Sadhasivam wrote:
> On Wed, Apr 01, 2020 at 12:49:26PM +0530, Amit Singh Tomar wrote:
>> This patch adds "actions,owl-uart" string to the owl uart driver. It
>> is also defined in Linux kernel.
>>
>> Reviewed-by: Andre Przywara <andre.przyw...@arm.com>
>> Signed-off-by: Amit Singh Tomar <amittome...@gmail.com>
>> ---
>> Changes since v8:
>> * No changes.
>> Changes since v7:
>> * No changes.
>> Changes since v6:
>> * Added Reviewd-by tag.
>> Changes since v5:
>> * Moved it to from 06/11 to 03/11.
>> * Used appropriate commit message.
>> * Removed the reviwed-by tag.
>> Changes since v4:
>> * Moved it to from 09/11 to 06/11.
>> Changes since v3:
>> * Used only owl-uart for compatible string.
>> Changes since v2:
>> * No changes.
>> Changes since v1:
>> * No changes.
>> ---
>> drivers/serial/serial_owl.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/serial/serial_owl.c b/drivers/serial/serial_owl.c
>> index 7ead73e..539acdc 100644
>> --- a/drivers/serial/serial_owl.c
>> +++ b/drivers/serial/serial_owl.c
>> @@ -121,6 +121,7 @@ static const struct dm_serial_ops owl_serial_ops = {
>>
>> static const struct udevice_id owl_serial_ids[] = {
>> { .compatible = "actions,s900-serial" },
>
> This should've been removed here itself as opposed to in devicetree sync
> patch.
But this would break S900, because the Bubblegum DT still uses that string.
If you sync the DT before, you have a similar problem, so we have to
change the DT and the driver string in *one* patch, which is what patch
04/12 does.
Cheers,
Andre
> But I don't warrant a new series for this change.
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org>
>
> Thanks,
> Mani
>
>> + { .compatible = "actions,owl-uart" },
>> { }
>> };
>>
>> --
>> 2.7.4
>>
