>-----Original Message-----
>From: U-Boot <u-boot-boun...@lists.denx.de> On Behalf Of
>andy.t...@nxp.com
>Sent: Friday, April 3, 2020 12:30 PM
>To: Priyanka Jain <priyanka.j...@nxp.com>
>Cc: Mingkai Hu <mingkai...@nxp.com>; Rajesh Bhagat
><rajesh.bha...@nxp.com>; u-boot@lists.denx.de; Andy Tang
><andy.t...@nxp.com>
>Subject: [PATCH] armv8: ls1046ardb: add new 16GB udimm memory support
>
>From: Yuantian Tang <andy.t...@nxp.com>
>
>Add this udimm memory support on ls1046ardb board.
What is this?
I see in code, you are adding DIMM specific parameter to support new frequency.
Is this code changes because you are adding a different DIMM or adding support 
for new frequency?
If new DIMM, What if someone tried to use the frequency "2133" with the 
original dim on board.

Please provide more details in description.

Thanks
Priyanka
>
>Signed-off-by: Yuantian Tang <andy.t...@nxp.com>
>---
> board/freescale/ls1046ardb/ddr.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/board/freescale/ls1046ardb/ddr.h
>b/board/freescale/ls1046ardb/ddr.h
>index 3b4d44d465..d401daa776 100644
>--- a/board/freescale/ls1046ardb/ddr.h
>+++ b/board/freescale/ls1046ardb/ddr.h
>@@ -32,6 +32,7 @@ static const struct board_specific_parameters udimm0[]
>= {
>       {2,  1350, 0, 8,     6, 0x0708090B, 0x0C0D0E09,},
>       {2,  1666, 0, 8,     7, 0x08090A0C, 0x0D0F100B,},
>       {2,  1900, 0, 8,     7, 0x09090B0D, 0x0E10120B,},
>+      {2,  2133, 0, 4,     7, 0x08090A0E, 0x1011120C,},
>       {2,  2300, 0, 8,     9, 0x0A0B0C10, 0x1213140E,},
>       {}
> };
>--
>2.17.1

Reply via email to