Hello Fabio,

On Wed, 2020-04-15 at 13:15 -0300, Fabio Estevam wrote:
> Hi Harald,
> 
> On Wed, Apr 15, 2020 at 12:54 PM Harald Seiler <h...@denx.de> wrote:
> 
> > +/ {
> > +       fec_vio: regulator-fec {
> > +               compatible = "regulator-fixed";
> > +
> > +               regulator-name = "fec-vio";
> > +               gpio = <&gpio1 7 GPIO_ACTIVE_HIGH>;
> 
> By looking at your board code, this should be GPIO_ACTIVE_LOW instead.

Yes, you are right, I will change this in v4.  Interestingly, it works
with both ACTIVE_LOW and ACTIVE_HIGH but removing the regulator entirely
breaks it.  Seems a bit weird to me ...

> > +               regulator-always-on;
> 
> This one could be removed since it has the FEC as a consumer.

I see, thanks!
-- 
Harald

Reply via email to