On 16. 04. 20 5:06, Simon Glass wrote: > At present if buildman reports an error, the travis build still succeeds. > > This is because the travis script does not stop when it sees errors; nor > does it automatically return the exit code. Also the current error > checking never triggers since 'ret' is not set. > > Fix this by setting 'ret' correctly. > > Signed-off-by: Simon Glass <s...@chromium.org> > --- > > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index b3253da13c3..e5b2b5e335e 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -208,7 +208,7 @@ script: > # > # Build a selection of boards if TEST_PY_BD is empty > - if [[ "${BUILDMAN}" != "" ]]; then > - tools/buildman/buildman -P -E -W ${BUILDMAN} ${OVERRIDE}; > + tools/buildman/buildman -P -E -W ${BUILDMAN} ${OVERRIDE} || ret=$?; > if [[ $ret -ne 0 ]]; then > tools/buildman/buildman -seP ${BUILDMAN}; > exit $ret; >
I am also missing ret=0; assignment which is also needed. Please also add Reported-by: Michal Simek <michal.si...@xilinx.com> to v2. Thanks, Michal