On Mon, 2010-16-08 at 12:33 +0200, Wolfgang Denk wrote: > > --- /dev/null > > +++ b/board/freescale/p1021mds/bcsr.h > > @@ -0,0 +1,18 @@ > > +/* > > + * Copyright (C) 2010 Freescale Semiconductor, Inc. > > + * > > + * This program is free software; you can redistribute it and/or modify it > > + * under the terms of the GNU General Public License as published by the > > Free > > + * Software Foundation; either version 2 of the License, or (at your > > option) > > + * any later version. > > + * > > + */ > > + > > +#ifndef __BCSR_H_ > > +#define __BCSR_H_ > > + > > +#include <common.h> > > + > > +/*BCSR Utils functions*/ > > +void reset_p1021mds_micrel_phy(void); > > +#endif /* __BCSR_H_ */ > > Please avoid adding a new header file just for this single prototype. This was copied from mpc8568mds/mpc8569mds. If it is not allowed anymore, I can remove it.
> Why do you need a separate one anyway? Because it is p1021mds board specific reset routine. > > Why cannot you implement this > in reset_phy() ? reset_phy() is a one time reset and called after eth_initialize(). But the board designer told me to reset phy for each UEC port before initializing it, otherwise the phy can not work properly. Haiying _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot