Hi Sean, >-----Original Message----- >From: Sean Anderson <sean...@gmail.com> >Sent: 03 May 2020 22:47 >To: Pragnesh Patel <pragnesh.pa...@sifive.com>; u-boot@lists.denx.de >Cc: atish.pa...@wdc.com; palmerdabb...@google.com; >bmeng...@gmail.com; Paul Walmsley <paul.walms...@sifive.com>; >ja...@amarulasolutions.com; Troy Benjegerdes ><troy.benjeger...@sifive.com>; anup.pa...@wdc.com; Sagar Kadam ><sagar.ka...@sifive.com>; r...@andestech.com; Lukas Auer ><lukas.a...@aisec.fraunhofer.de> >Subject: Re: [PATCH v7 16/22] riscv: Enable cpu clock if it is present > >[External Email] Do not click links or attachments unless you recognize the >sender and know the content is safe > >On 5/3/20 3:12 AM, Pragnesh Patel wrote: >> Hi Sean, >> >>> -----Original Message----- >>> From: Sean Anderson <sean...@gmail.com> >>> Sent: 02 May 2020 23:46 >>> To: Pragnesh Patel <pragnesh.pa...@sifive.com>; u-boot@lists.denx.de >>> Cc: atish.pa...@wdc.com; palmerdabb...@google.com; >>> bmeng...@gmail.com; Paul Walmsley <paul.walms...@sifive.com>; >>> ja...@amarulasolutions.com; Troy Benjegerdes >>> <troy.benjeger...@sifive.com>; anup.pa...@wdc.com; Sagar Kadam >>> <sagar.ka...@sifive.com>; r...@andestech.com; Lukas Auer >>> <lukas.a...@aisec.fraunhofer.de> >>> Subject: Re: [PATCH v7 16/22] riscv: Enable cpu clock if it is >>> present >>> >>> [External Email] Do not click links or attachments unless you >>> recognize the sender and know the content is safe >>> >>> On 5/2/20 6:06 AM, Pragnesh Patel wrote: >>>> The cpu clock is probably already enabled if we are executing code >>>> (though we could be executing from a different core). This patch >>>> prevents the cpu clock or its parents from being disabled. >>>> >>>> Signed-off-by: Sean Anderson <sean...@gmail.com> >>> >>> If you make substantial changes can you please make a note of it in >>> the commit? I did not sign off on *this* code. >> >> This patch is copied from your v9 series [1] and I made some changes, >> so the idea is to give credit to everyone who contributed. > >That's fine, just please make a note when you make substantial changes. >For example, you could write > >Signed-off-by: Sean Anderson <sean...@gmail.com> >Reviewed-by: Bin Meng <bmeng...@gmail.com> [set clock frequency from >clock-frequency property] >Signed-off-by: Pragnesh Patel <pragnesh.pa...@sifive.com> > >so it's more clear what changes have been made since this patch was posted >last.
Will take care in future. > >--Sean