On Wed, May 06, 2020 at 04:09:33PM +0800, Bin Meng wrote: > Hi Simon, > > On Tue, May 5, 2020 at 7:19 AM Simon Glass <s...@chromium.org> wrote: > > > > This function only has three lines of code in it so inline it. > > What's our guideline for inlining functions? To me if there is only > one line, inline the function looks good to me. But 3 lines? I am not > sure. > > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > --- > > > > cmd/bdinfo.c | 11 +++-------- > > 1 file changed, 3 insertions(+), 8 deletions(-)
I'm ambivalent on if this should be moved in to the caller or not (I first read inlining as marking with inline). It kinda matters how the overall function looks when you're done. -- Tom
signature.asc
Description: PGP signature
