On Tue, Feb 18, 2020 at 08:39:42AM +0000, Rasmus Villemoes wrote:
> CMD_EEPROM and ENV_IS_IN_EEPROM can be selected independently, and
> cmd/eeprom.o gets built in either case, so whether to declare the real
> prototypes needs to follow the same logic as whether cmd/eeprom.c is
> built. Otherwise a ENV_IS_IN_EEPROM=y, CMD_EEPROM=n build fails
>
> cmd/eeprom.c:73:1: error: expected identifier or ‘(’ before ‘{’ token
> {
>
> While at it, fix the dummy replacements (at least assuming they are
> meant to allow the code to compile) - they need to have the same type
> as the expression they replace, or one gets errors such as
>
> env/eeprom.c: In function ‘eeprom_bus_read’:
> env/eeprom.c:37:8: error: void value not ignored as it ought to be
> rcode = eeprom_read(dev_addr, offset, buffer, cnt);
>
> Signed-off-by: Rasmus Villemoes <rasmus.villem...@prevas.dk>
> Reviewed-by: Tom Rini <tr...@konsulko.com>[I had asked for a follow-up cleanup, but this is still worth taking, so...] Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: PGP signature
