Hi Rayagonda, On Thu, 30 Apr 2020 at 05:10, Rayagonda Kokatanur <rayagonda.kokata...@broadcom.com> wrote: > > Hi Simon, > > On Wed, Apr 29, 2020 at 11:34 PM Simon Glass <s...@chromium.org> wrote: > > > > Hi Rayagonda, > > > > +Stephen Warren > > > > On Wed, 29 Apr 2020 at 10:35, Rayagonda Kokatanur > > <rayagonda.kokata...@broadcom.com> wrote: > > > > > > Parse different gpio properties from dt as part of probe > > > function. This detail will be used to enable pinctrl pad > > > later when gpio lines are requested. > > > > > > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokata...@broadcom.com> > > > --- > > > drivers/pinctrl/pinctrl-single.c | 62 +++++++++++++++++++++++++++++++- > > > 1 file changed, 61 insertions(+), 1 deletion(-) > > > > Can you please add the binding and a test? Also I think this feature > > should be behind a Kconfig flag to avoid code-size increase. > > Sorry I didn't get it, please elaborate "binding and a test". > You mean dt-binding document and test procedure.
That's right. For the tests, it seems we do not have a test/dm/pinctrl.c but we need one, something simple to start. The binding will help explain what is going on. > > This feature is added by referring to linux pinctrl-single driver and > code is in align with linux driver. > This feature is going to be used in most of the gpio controllers where > they have pin controllers to select > different modes of gpio lines. I feel this feature should be part of > the driver by default. OK makes sense. Re the Kconfig flag, U-Boot SPL runs in a tight environment. So when we add new features we sometimes put them behind a flag so that it does not bloat SPL. Regards, Simon
