On 11.05.2020 21:47, Matthias Brugger wrote:
>>>> static void rpi4_create_pcie_xhci_mapping(void)
>>>> +{
>>>> + unsigned sect = BCM2711_RPI4_PCIE_XHCI_MMIO_VIRT >> MMU_SECTION_SHIFT;
>>>> + phys_addr_t phys_addr = BCM2711_RPI4_PCIE_XHCI_MMIO_PHYS;
>>>> + unsigned int size = BCM2711_RPI4_PCIE_XHCI_MMIO_SIZE;
>>>> +
>>>> + while (size) {
>>>> + set_section_phys(sect, phys_addr, DCACHE_OFF);
>>>> + sect++;
>>>> + phys_addr += MMU_SECTION_SIZE;
>>>> + size -= MMU_SECTION_SIZE;
>>>> + }
>>>> +}
>>> I wonder if we can't do all this in the pcie driver probe function. Maybe
>>> we can
>>> create a new function like mmu_set_region_dcache_behaviour_phys which
>>> allows us
>>> to update a mapping that's not 1:1.
>>>
>>> Tom what do you think?
>> I think a harder look at how PowerPC handled this situation is in order,
>> and then following / extending that path is in order.
>>
> Thanks Tom for the feedback.
> Sylwester, I propose to split the series in two. One for adding the driver to
> 64-bit U-Boot and another one to add support for rpi_4_32b_defconfig. This way
> we could get the driver merged for 2020.07 for sure, while 32-bit parts could
> take more cycles to be ready. What do you think?
Sounds good to me, I will split the series and will post the 64-bits part
first, while we work on the 32-bit part according to your suggestions.
--
Thanks,
Sylwester
