On Wed, May 20, 2020 at 12:09 PM Simon Glass <s...@chromium.org> wrote: > > HI Masahiro, > > On Tue, 19 May 2020 at 20:44, Masahiro Yamada > <yamada.masah...@socionext.com> wrote: > > > > arch/arm/include/asm/system.h declares psci_arch_init(), but it is > > surrounded by #ifdef CONFIG_ARMV8_PSCI. > > > > psci_arch_init() is called for CONFIG_ARMV7_PSCI too. Add the missing > > function declaration. > > > > Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> > > --- > > > > arch/arm/include/asm/system.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/include/asm/system.h b/arch/arm/include/asm/system.h > > index 1e3f574403..7a40b56acd 100644 > > --- a/arch/arm/include/asm/system.h > > +++ b/arch/arm/include/asm/system.h > > @@ -528,6 +528,7 @@ void mmu_page_table_flush(unsigned long start, unsigned > > long stop); > > > > #ifdef CONFIG_ARMV7_PSCI > > void psci_arch_cpu_entry(void); > > +void psci_arch_init(void); > > Could you add a function comment too?
Sorry, I can't. It was a long time ago that I worked on the psci implementation for my board, so I forgot what psci_arch_init() was actually intended. I was only interested in fixing -Wmissing-prototypes warning here. None of the remaining functions are documented, so "please also do this while you are here" is not a reasonable request, I think. If people are happy with not fixing the warning, please feel free to ignore this patch. > > u32 psci_version(void); > > s32 psci_features(u32 function_id, u32 psci_fid); > > s32 psci_cpu_off(void); > > -- > > 2.25.1 > > > > Regards, > Simon -- Best Regards Masahiro Yamada
