Le 27/08/2010 07:25, Heiko Schocher a écrit : >>>> +#define MVTWSI_STATUS_DATA_R_NAK 0x58 /* our NAK, not the >>>> slave's */ >>> >>> line too long. >> >> Checkpatch did not complain on this one. Is there a specific line length >> contraint beside passing checkpatch? > > Yep, 78 characters.
Ok. I added a possibility for checkpatch to accept a custom line length; I'll try and push that to the lkml. Meanwhile, it showed me three lines beyond 78 characters, fixed. >> Which blank line exactly? Between the comment block and code? If so, > > Yes. >> does this apply everywhere, i.e. after the topmost license comment >> block, before blocks of #define, etc? > > No, there, it is Ok. Fixed, thanks. >> As a side note, if V2 gets Acked by Prafulla and you, can you add the >> commit to your i2c tree and ask for a new pull? Anyway, Wolfgang said he >> won't resume activity on u-boot before sep 5th. > > Yes, if I and Prafulla accept it, this is the usual way. Here you go, then. :) Thanks for your review. Amicalement, -- Albert. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
