> Subject: [PATCH] mmc: omap_hsmmc: Add guards around > omap_hsmmc_get_cfg() > > We only call the function omap_hsmmc_get_cfg in the case of OMAP34XX or > when we have to iodelay recalibration. Add guards for these checks as clang > will otherwise warn. > > Cc: Peng Fan <peng....@nxp.com> > Cc: Lokesh Vutla <lokeshvu...@ti.com> > Signed-off-by: Tom Rini <tr...@konsulko.com> > --- > Aside, Lokesh, can you please add drivers/mmc/omap_hsmmc.c to the > general TI entry MAINTAINERS entry? Thanks! > --- > drivers/mmc/omap_hsmmc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c > index 8636cd713a36..0e05fe4cfcbb 100644 > --- a/drivers/mmc/omap_hsmmc.c > +++ b/drivers/mmc/omap_hsmmc.c > @@ -175,6 +175,8 @@ static inline struct omap_hsmmc_data > *omap_hsmmc_get_data(struct mmc *mmc) > return (struct omap_hsmmc_data *)mmc->priv; #endif } > + > +#if defined(CONFIG_OMAP34XX) || > defined(CONFIG_IODELAY_RECALIBRATION) > static inline struct mmc_config *omap_hsmmc_get_cfg(struct mmc *mmc) > { #if CONFIG_IS_ENABLED(DM_MMC) @@ -184,6 +186,7 @@ static inline > struct mmc_config *omap_hsmmc_get_cfg(struct mmc *mmc) > return &((struct omap_hsmmc_data *)mmc->priv)->cfg; #endif } > +#endif > > #if defined(OMAP_HSMMC_USE_GPIO) > && !CONFIG_IS_ENABLED(DM_MMC) static int > omap_mmc_setup_gpio_in(int gpio, const char *label) > -- > 2.17.1
Reviewed-by: Peng Fan <peng....@nxp.com>