Hi Marek,
> From: Marek Vasut <ma...@denx.de>
> Sent: mercredi 13 mai 2020 15:54
>
> On 5/13/20 3:17 PM, Patrick DELAUNAY wrote:
> > Hi David,
> >
> >> From: David Wu <david...@rock-chips.com>
> >> Sent: mardi 12 mai 2020 11:56
> >>
> >> For others using, clk_rx and clk_tx may not be necessary, and their
> >> clock names are different.
> >>
> >> Signed-off-by: David Wu <david...@rock-chips.com>
> >> ---
> >>
> >> Changes in v2:
> >> - Don't change the Rx and Tx clock names. (Patrice, Stephen)
> >>
> >> drivers/net/dwc_eth_qos.c | 61
> >> +++++++++++++++++++--------------------
> >> 1 file changed, 29 insertions(+), 32 deletions(-)
> >>
[...]
> >
> > These clock are mandatory for STM32 glue as explain in Linux binding
> > Documentation/devicetree/bindings/net/stm32-dwmac.txt
> >
> > But I fact when when I check the code, I see perhaps an issue in the
> > current U-
> Boot glue:
> > we don't select the STM32 glue for the correct compatible, I think I
> > will push
> >
> > static const struct udevice_id eqos_ids[] = {
> > {
> > .compatible = "nvidia,tegra186-eqos",
> > .data = (ulong)&eqos_tegra186_config
> > },
> > {
> > - .compatible = "snps,dwmac-4.20a",
> > + .compatible = "st,stm32mp1-dwmac",
> > .data = (ulong)&eqos_stm32_config
> > },
> > {
> > .compatible = "fsl,imx-eqos",
> > .data = (ulong)&eqos_imx_config
> > },
> >
> > { }
> > };
> >
> > Then you can manage your own glue for rockchip ETH for your compatible.
>
> You might even want to drop the tegra support on ARM32 , thus save space by
> dropping useless code.
For information I push 2 patches after this remark:
[1] net: dwc_eth_qos: update the compatible supported for STM32
http://patchwork.ozlabs.org/project/uboot/patch/20200514130023.15030-1-patrick.delau...@st.com/
[2] net: dwc_eth_qos: add Kconfig option to select supported configuration
http://patchwork.ozlabs.org/project/uboot/list/?series=181931
