On Friday, September 03, 2010 17:23:43 Reinhard Meyer wrote: > On 03.09.2010 23:03, Mike Frysinger wrote: > >> not sure, however, if calling spi_setup_slave() is ok at this point. > > > > i believe the func should only doing validation on the arguments. it > > shouldnt need to talk to any actual hardware. maybe this needs > > codifying in the API documentation. > > In atmel_spi.c it sets up the csr[indexed by cs=0..3] register with clock, > phase and polarity. > That's harmless, but might need some rethinking there.
i'm not familiar with the Atmel SPI controller, but my gut reaction is that register values should be calculated in spi_setup_slave(), stored in the internal xxx_spi_slave struct, and then written at spi_claim_bus() time. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
