Hello Simon, On Thu, 2020-07-02 at 21:50 -0600, Simon Glass wrote: > Hi, > > On Wed, 1 Jul 2020 at 10:30, Anastasiia Lukianenko < > vicooo...@gmail.com> wrote: > > > > From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> > > > > Make required updates to run on u-boot. Strip functionality > > not needed by U-boot. > > > > Signed-off-by: Oleksandr Andrushchenko < > > oleksandr_andrushche...@epam.com> > > Signed-off-by: Anastasiia Lukianenko < > > anastasiia_lukiane...@epam.com> > > --- > > drivers/xen/Makefile | 1 + > > drivers/xen/events.c | 177 > > +++++++++++++++++++++++++++++++++++++++ > > drivers/xen/hypervisor.c | 6 +- > > include/xen/events.h | 47 +++++++++++ > > 4 files changed, 228 insertions(+), 3 deletions(-) > > create mode 100644 drivers/xen/events.c > > create mode 100644 include/xen/events.h > > > > diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile > > index 1211bf2386..0ad35edefb 100644 > > --- a/drivers/xen/Makefile > > +++ b/drivers/xen/Makefile > > @@ -3,3 +3,4 @@ > > # (C) Copyright 2020 EPAM Systems Inc. > > > > obj-y += hypervisor.o > > +obj-y += events.o > > diff --git a/drivers/xen/events.c b/drivers/xen/events.c > > new file mode 100644 > > index 0000000000..eddc6b6e29 > > --- /dev/null > > +++ b/drivers/xen/events.c > > @@ -0,0 +1,177 @@ > > +/* -*- Mode:C; c-basic-offset:4; tab-width:4 -*- > > SPDX is needed on files
Ok, will add. > > > + > > ******************************************************************* > > ********* > > + * (C) 2003 - Rolf Neugebauer - Intel Research Cambridge > > + * (C) 2005 - Grzegorz Milos - Intel Research Cambridge > > + * (C) 2020 - EPAM Systems Inc. > > + > > ******************************************************************* > > ********* > > + * > > + * File: events.c > > + * Author: Rolf Neugebauer (neuge...@dcs.gla.ac.uk) > > + * Changes: Grzegorz Milos (gm...@cam.ac.uk) > > + * > > + * Date: Jul 2003, changes Jun 2005 > > + * > > + * Environment: Xen Minimal OS > > + * Description: Deals with events received on event channels > > + * > > + > > ******************************************************************* > > ********* > > Can you drop these stars and use the normal U-Boot format? Ok, will update all the files. > > > + */ > > +#include <common.h> > > +#include <log.h> > > + > > +#include <asm/io.h> > > +#include <asm/xen/system.h> > > + > > +#include <xen/events.h> > > +#include <xen/hvm.h> > > + > > +#define NR_EVS 1024 > > + > > +/* this represents a event handler. Chaining or sharing is not > > allowed */ > > +typedef struct _ev_action_t { > > Please don't use typedefs. Ok. > > Also there should be comments on functions, particularly those in the > header file. Ok, will add comments in next version. > > Are you trying to keep the source similar to an upstream version? It seems that after this review we are stepping away from Mini-OS anyway (like removing x86 code etc), so it is ok not to keep the source close to the original code. > > Regards, > SImon Regards, Anastasiia