On 6/25/20 1:59 AM, Patrick Delaunay wrote: > Add basic test to persistent environment in ext4: > save and load in host ext4 file 'uboot.env'. > > On first execution an empty EXT4 file system is created in > persistent data dir: env.ext4.img.
Acked-by: Stephen Warren <swar...@nvidia.com> A couple nits below; feel free not to skip them, but if you end up sending another revision for other reasons, may as well fix them. > diff --git a/test/py/tests/test_env.py b/test/py/tests/test_env.py > +from subprocess import call, check_call, CalledProcessError I believe only CalledProcessError is used now. > +def test_env_ext4(state_test_env): > + > + """Test ENV in EXT4 on sandbox.""" > + c = state_test_env.u_boot_console > + fs_img = '' "None" would be a better unset value.
