On Mon, Jul 20, 2020 at 01:33:30PM +0530, Jagan Teki wrote: > On Thu, May 14, 2020 at 6:03 PM Tom Rini <tr...@konsulko.com> wrote: > > > > Copy these from Linux v5.7-rc5 tag. > > > > This brings in some handy new attributes and is otherwise important to > > keep in sync. > > > > We drop the reference to smp_read_barrier_depends() as it is not > > relevant on the architectures we support at this time, based on where > > it's implemented in Linux today. We drop the call to kasan_check_read() > > as that is not relevant to U-Boot as well. > > > > Cc: Masahiro Yamada <yamada.masah...@socionext.com> > > Signed-off-by: Tom Rini <tr...@konsulko.com> > > --- > > Look like this make build failure if we disable the default > configuration. Kind of bistability issue indeed. > > For example, If we disable CONFIG_RAM_ROCKCHIP_DEBUG (which is enabled > by default) make build failure. > > Build error log: > > drivers/ram/rockchip/sdram_common.o: In function `sdram_print_dram_type': > /w/u-boot/./arch/arm/include/asm/arch-rockchip/sdram_common.h:120: > multiple definition of `sdram_print_dram_type' > drivers/ram/rockchip/sdram_rk3399.o:/w/u-boot/./arch/arm/include/asm/arch-rockchip/sdram_common.h:120: > first defined here > drivers/ram/rockchip/sdram_common.o: In function `sdram_print_dram_type': > /w/u-boot/./arch/arm/include/asm/arch-rockchip/sdram_common.h:120: > multiple definition of `sdram_print_ddr_info' > drivers/ram/rockchip/sdram_rk3399.o:/w/u-boot/drivers/ram/rockchip/sdram_rk3399.c:3175: > first defined here > drivers/ram/rockchip/sdram_common.o: In function `sdram_print_dram_type': > /w/u-boot/./arch/arm/include/asm/arch-rockchip/sdram_common.h:120: > multiple definition of `sdram_print_stride' > drivers/ram/rockchip/sdram_rk3399.o:/w/u-boot/drivers/ram/rockchip/sdram_rk3399.c:3175: > first defined here > make[3]: *** [scripts/Makefile.build:342: > drivers/ram/rockchip/built-in.o] Error 1 > make[2]: *** [scripts/Makefile.build:419: drivers/ram/rockchip] Error 2
Likely that an inline function is missing 'static'. I thought I had included the fixes for those kinds of problems in the right order such that we kept bisectability, sorry. -- Tom
signature.asc
Description: PGP signature