Hi Lokesh,

On 27/07/20 3:15 pm, Lokesh Vutla wrote:
> Add the basic a72 dts for j7200. Following nodes were supported:
> - UART
> - MMC SD
> - I2C
> - TISCI communication
> 
> Signed-off-by: Lokesh Vutla <lokeshvu...@ti.com>
> Signed-off-by: Vignesh Raghavendra <vigne...@ti.com>
> Signed-off-by: Vishal Mahaveer <vish...@ti.com>
> Signed-off-by: Faiz Abbas <faiz_ab...@ti.com>
> ---
>   arch/arm/dts/Makefile                         |   3 +-
>   .../k3-j7200-common-proc-board-u-boot.dtsi    |  92 +++++
>   arch/arm/dts/k3-j7200-common-proc-board.dts   |  94 ++++++
>   arch/arm/dts/k3-j7200-main.dtsi               | 313 ++++++++++++++++++
>   arch/arm/dts/k3-j7200-mcu-wakeup.dtsi         | 117 +++++++
>   arch/arm/dts/k3-j7200-som-p0.dtsi             |  29 ++
>   arch/arm/dts/k3-j7200.dtsi                    | 175 ++++++++++
>   7 files changed, 822 insertions(+), 1 deletion(-)
>   create mode 100644 arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi
>   create mode 100644 arch/arm/dts/k3-j7200-common-proc-board.dts
>   create mode 100644 arch/arm/dts/k3-j7200-main.dtsi
>   create mode 100644 arch/arm/dts/k3-j7200-mcu-wakeup.dtsi
>   create mode 100644 arch/arm/dts/k3-j7200-som-p0.dtsi
>   create mode 100644 arch/arm/dts/k3-j7200.dtsi
> 


This patch is missing IO expander nodes that are used by MMC/SD (same is 
present in 16/18)
Could you squash the below diff into this patch while merging/reposting?

--><8--

diff --git a/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi 
b/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi
index 593417565e..10bb069492 100644
--- a/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi
+++ b/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi
@@ -90,3 +90,15 @@
 &wkup_i2c0 {
        u-boot,dm-spl;
 };
+
+&main_i2c0 {
+       u-boot,dm-spl;
+};
+
+&main_i2c0_pins_default {
+       u-boot,dm-spl;
+};
+
+&exp2 {
+       u-boot,dm-spl;
+};
diff --git a/arch/arm/dts/k3-j7200-common-proc-board.dts 
b/arch/arm/dts/k3-j7200-common-proc-board.dts
index 3f33fb5650..537ef2a79d 100644
--- a/arch/arm/dts/k3-j7200-common-proc-board.dts
+++ b/arch/arm/dts/k3-j7200-common-proc-board.dts
@@ -23,6 +23,15 @@
        };
 };
 
+&main_pmx0 {
+       main_i2c0_pins_default: main-i2c0-pins-default {
+               pinctrl-single,pins = <
+                       J721E_IOPAD(0xd4, PIN_INPUT_PULLUP, 0) /* (V3) I2C0_SCL 
*/
+                       J721E_IOPAD(0xd8, PIN_INPUT_PULLUP, 0) /* (W2) I2C0_SDA 
*/
+               >;
+       };
+};
+
 &wkup_uart0 {
        /* Wakeup UART is used by System firmware */
        status = "disabled";
@@ -92,3 +101,23 @@
        no-1-8-v;
        sdhci-caps-mask = <0x8000000F 0x0>;
 };
+
+&main_i2c0 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&main_i2c0_pins_default>;
+       clock-frequency = <400000>;
+
+       exp1: gpio@20 {
+               compatible = "ti,tca6416";
+               reg = <0x20>;
+               gpio-controller;
+               #gpio-cells = <2>;
+       };
+
+       exp2: gpio@22 {
+               compatible = "ti,tca6424";
+               reg = <0x22>;
+               gpio-controller;
+               #gpio-cells = <2>;
+       };
+};

[...]

Reply via email to