> -----Original Message-----
> From: Marek Vasut <ma...@denx.de>
> Sent: Thursday, August 6, 2020 5:56 PM
> To: Ooi, Joyce <joyce....@intel.com>; Simon Goldschmidt
> <simon.k.r.goldschm...@gmail.com>; Tan, Ley Foon
> <ley.foon....@intel.com>; See, Chin Liang <chin.liang....@intel.com>;
> Nguyen, Dinh <dinh.ngu...@intel.com>
> Cc: u-boot@lists.denx.de; Chang, Rebecca Swee Fun
> <rebecca.swee.fun.ch...@intel.com>; Lim, Elly Siew Chin
> <elly.siew.chin....@intel.com>
> Subject: Re: [PATCH] configs: socfpga: add CONFIG_BOOTCOMMAND for
> cyclone5
> 
> On 8/6/20 11:08 AM, Ooi, Joyce wrote:
> > From: Joyce Ooi <joyce....@intel.com>
> >
> > Add CONFIG_BOOTCOMMAND in cyclone5 defconfig to run fatscript and
> > enable FPGA bridge
> >
> > Signed-off-by: Joyce Ooi <joyce....@intel.com>
> > ---
> >  configs/socfpga_cyclone5_defconfig | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/configs/socfpga_cyclone5_defconfig
> > b/configs/socfpga_cyclone5_defconfig
> > index 1633ca1deb5..132b7b7fa81 100644
> > --- a/configs/socfpga_cyclone5_defconfig
> > +++ b/configs/socfpga_cyclone5_defconfig
> > @@ -8,7 +8,8 @@ CONFIG_TARGET_SOCFPGA_CYCLONE5_SOCDK=y
> >  CONFIG_SPL_TEXT_BASE=0xFFFF0000
> >  CONFIG_DISTRO_DEFAULTS=y
> >  CONFIG_FIT=y
> > -# CONFIG_USE_BOOTCOMMAND is not set
> > +CONFIG_USE_BOOTCOMMAND=y
> > +CONFIG_BOOTCOMMAND="run fatscript; bridge enable; run
> distro_bootcmd"
> 
> What is 'fatscript' ? Also, this breaks on systems where the FPGA isn't 
> loaded,
> as it enables bridges to nowhere.
I missed out on adding the fatscript. I'll add in my next version.

For the bridge enabling, I'll add a checking to check if FPGA is in user mode 
before enabling the bridge.

Reply via email to