Hello Tom, Am Donnerstag, den 20.08.2020, 09:22 -0400 schrieb Tom Rini: > On Thu, Aug 20, 2020 at 08:55:30AM +0200, Teresa Remmet wrote: > > > Add support PHYTEC phyCORE-i.MX8MM SOM. > > > > Supported features: > > - 2GB LPDDR4 RAM > > - 1x 1Gbit Ethernet > > - eMMC > > - external SD > > - debug UART3 > > - watchdog > > - i2c eeprom > > [snip] > > +#define CONFIG_EXTRA_ENV_SETTINGS \ > > + "image=Image\0" \ > > + "console=ttymxc2,115200\0" \ > > + "fdt_addr=0x44000000\0" \ > > + "fdt_high=0xffffffffffffffff\0" \ > > Disabling fdt relocation is a bad idea. If U-Boot is moving it to > outside of kernel visible memory you want to use bootm_size to limit > the window to what will be visible to the kernel.
I will remove it. > > [snip] > > +/* Link Definitions */ > > +#define CONFIG_LOADADDR 0x40480000 > > +#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR > > This ends up with a fairly small gap between the kernel and the > device > tree and is a good way to end up with the kernel corrupting the > device > tree. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm64/booting.rst > is a good reference but I think in short I think you might want to > move > fdt_addr up to 0x48000000. Thanks! I will change this also in v2. Thanks for explanation and review. Teresa >