Thanks Kuldeep for the review, will do the changes.
> -----Original Message----- > From: Kuldeep Singh <kuldeep.si...@nxp.com> > Sent: Wednesday, August 26, 2020 3:48 PM > To: u-boot@lists.denx.de; Meenakshi Aggarwal > <meenakshi.aggar...@nxp.com> > Cc: Ioana Ciornei <ioana.cior...@nxp.com>; Qiang Zhao > <qiang.z...@nxp.com>; Hui Song <hui.son...@nxp.com>; Manish Tomar > <manish.to...@nxp.com>; Vikas Singh <vikas.si...@nxp.com>; Priyanka > Jain <priyanka.j...@nxp.com>; Ashish Kumar <ashish.ku...@nxp.com> > Subject: RE: [EXT] [PATCH] armv8: lx2162aqds: Add support for LX2162AQDS > platform > > Hi Meenakshi, > > [..] > > This patch add base support for LX2162 QDS board. > > LX2162 is LX2160 based SoC, it has same die as of LX2160 with > > different packaging. > > Board support's 4GB ddr memory, i2c, micro-click module, microSD card, > > serial console, qspi nor flash, qsgmii, sgmii, 25g, 40g, 50g network > > s/qspi/flexspi > > > interface,one usb 3.0 and serdes interface to support three x1gen3 > > pcie interface. > > [...] > > diff --git a/arch/arm/dts/fsl-lx2162a-qds.dts > > b/arch/arm/dts/fsl-lx2162a- qds.dts new file mode 100644 index > > 0000000..2a498af > > --- /dev/null > > +++ b/arch/arm/dts/fsl-lx2162a-qds.dts > > @@ -0,0 +1,107 @@ > > +&fspi { > > + bus-num = <0>; > > + status = "okay"; > > + fspi-has-second-chip; > > + > > + qflash0: mt35xu512g@0 { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + compatible = "spi-flash"; > > + spi-max-frequency = <20000000>; > > + reg = <0>; > > + /* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode > */ > > + fspi-rx-bus-width = <8>; /* 8 FSPI Rx lines */ > > + fspi-tx-bus-width = <1>; /* 1 FSPI Tx line */ > > + }; > > + > > + /* > > + * MCR2[SAMEDEVICEEN] bit is enabled in FlexSPI controller for > > + * LX2160ARDB and LX2160AQDS board. Both these has same type > > + of > > flash > > + * slave devices connected on both A0 and A1. > > + * No need to provide node info for second flash device. > > + */ > > +}; > > Please align fspi node properties with lx2160a-qds added in commit > 4c1a52294f23 ("arm: dts: lx2160aqds: Add FSPI node properties"). > This version has few unused options which are not required by new driver > anymore and also the comment related to MCR2[SAVEDEVICEEN] is not valid > now. > > [..] > > diff --git a/configs/lx2162aqds_tfa_SECURE_BOOT_defconfig > > b/configs/lx2162aqds_tfa_SECURE_BOOT_defconfig > > new file mode 100644 > > index 0000000..b2ae694 > > --- /dev/null > > +++ b/configs/lx2162aqds_tfa_SECURE_BOOT_defconfig > > @@ -0,0 +1,83 @@ > > +CONFIG_DM_SPI_FLASH=y > > +CONFIG_SPI_FLASH=y > > +CONFIG_SPI_FLASH_SPANSION=y > > No Spansion flash on lx2160/lx2162 qds boards. Please unset this option. > Same goes with other defconfigs as well. > > And CONFIG_ENV_OVERWRITE is not required to reprogram "ethaddr" > values? > > [..] > > diff --git a/include/configs/lx2162aqds.h > > b/include/configs/lx2162aqds.h new file mode 100644 index > > 0000000..d364660 > > --- /dev/null > > +++ b/include/configs/lx2162aqds.h > > @@ -0,0 +1,175 @@ > > +/* DSPI */ > > +#ifdef CONFIG_FSL_DSPI > > +#define CONFIG_SPI_FLASH_SST > > +#define CONFIG_SPI_FLASH_EON > > +#endif > > Please move these SPI_FLASH options from header to defconfig similar to > lx2160a-qds. > > -Kuldeep