On Fri, Aug 14, 2020 at 3:55 PM Wolfgang Wallner <wolfgang.wall...@br-automation.com> wrote: > > The command 'mtrr' does not recognize the 'list' subcommand any more > since the code restructuring in commit b2a76b3fe75a ("x86: mtrr: > Restructure so command execution is in one place"). > > The if-else parsing the command arguments does not take 'list' into > account: the if-branch is intended for no subcommands, the else-branch > is intended for the non-list subcommands (which all expect additional > arguments). Calling the 'mtrr list' subcommand leads to a "return > CMD_RET_USAGE" in the else-branch. > > Fix this by changing the else-branch to explicitly checking for > if (cmd != 'l'). > > Fixes: b2a76b3fe75a ("x86: mtrr: Restructure so command execution is in one > place") > > Signed-off-by: Wolfgang Wallner <wolfgang.wall...@br-automation.com> > > --- > > cmd/x86/mtrr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >
Reviewed-by: Bin Meng <bmeng...@gmail.com> Tested-by: Bin Meng <bmeng...@gmail.com>