Re: [PATCH] spl: Avoid printing boot device if silent console is enabled

[Stefan Roese]

On 03.09.20 19:25, Otavio Salvador wrote:

Signed-off-by: Otavio Salvador <ota...@ossystems.com.br>
---

  common/spl/spl.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/common/spl/spl.c b/common/spl/spl.c
index 4840d1d367..63c48fbf33 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -552,7 +552,9 @@ static int boot_from_devices(struct spl_image_info 
*spl_image,
                struct spl_image_loader *loader;

loader = spl_ll_find_loader(spl_boot_list[i]);

-#if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
+#if defined(CONFIG_SPL_SERIAL_SUPPORT) \
+    && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)    \
+    && !defined(CONFIG_SILENT_CONSOLE)

Nitpicking:
I think its preferred to put the "&&" (or "||") at the end of the line.

Other than that:

Reviewed-by: Stefan Roese <s...@denx.de>

Thanks,
Stefan