Hi Pratyush, On Tue, 8 Sep 2020 at 21:53, Pratyush Yadav <p.ya...@ti.com> wrote: > > On 08/09/20 05:56PM, Simon Glass wrote: > > On Mon, 7 Sep 2020 at 23:40, Pratyush Yadav <p.ya...@ti.com> wrote: > > > > > > From: Jean-Jacques Hiblot <jjhib...@ti.com> > > > > > > Add a test to verify that GPIOs can be acquired/released using the managed > > > API. Also check that the GPIOs are released when the consumer device is > > > removed. > > > > > > Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> > > > Signed-off-by: Pratyush Yadav <p.ya...@ti.com> > > > --- > > > arch/sandbox/dts/test.dts | 10 ++++ > > > test/dm/bus.c | 2 +- > > > test/dm/gpio.c | 102 ++++++++++++++++++++++++++++++++++++++ > > > test/dm/test-fdt.c | 6 +-- > > > 4 files changed, 116 insertions(+), 4 deletions(-) > > > > Reviewed-by: Simon Glass <s...@chromium.org> > > Thanks. > > > Although I don't see a change log, so this is a bit blind. > > The changelog is in the cover letter [0]. Copy-pasing the parts relevant > to this patch: > > - Move "another-test" node down the order to make sure > dm_test_fdt_uclass_seq() continues to work. > - Bump num_devices to 9 in dm_test_bus_children(), dm_test_fdt(), and > dm_test_uclass_foreach() to fix broken tests. > - s/DM_TESTF/UT_TESTF/g
OK ta. I don't see it if it is in the cover letter. It's nice to have it in both places. > > [0] I haven't figured out a workflow that lets me easily record the > changelog on a per-patch basis. Maybe I can write some scripts around > git-notes for that? Dunno. You can use patman which is conveniently in the U-Boot tree and does this along with automation of various other steps for emailing patches. Regards, Simon