On Wed, Sep 23, 2020 at 08:27:24PM +0200, Mauro Condarelli wrote: > Thanks for the review, > I'll prepare a v2 ASAP. > > On 9/23/20 12:05 AM, Daniel Schwierzeck wrote: > > Am Sonntag, den 20.09.2020, 21:21 -0400 schrieb Tom Rini: > >> On Sun, Sep 20, 2020 at 06:29:01PM +0200, Mauro Condarelli wrote: > >> > >>> Signed-off-by: Mauro Condarelli <mc5...@mclink.it> > >>> --- > >>> fs/squashfs/sqfs.c | 45 +++++++++++++++++++++++++-------------- > >>> fs/squashfs/sqfs_inode.c | 8 +++---- > >>> include/configs/vocore2.h | 2 +- > > remove that file which is unrelated to this patch > I will as this is fixing things just for my target and that is clearly wrong. > OTOH I feel some provision should be implemented (probably at Config.in > level) to ensure SquashFS has enough malloc space for its needs. > What are the best practices to handle this?
I don't recall why CONFIG_SYS_MALLOC_LEN hasn't been fully moved to Kconfig right now, there may be a good reason, or it just may be hard. I don't think Kconfig logic supports something like "depends on FOO > 0x4000" so the only way is to note in the squashfs help how much space may be used for malloc in worst cases. -- Tom
signature.asc
Description: PGP signature
