Dear [email protected],
In message <[email protected]> you wrote:
> From: Tirumala Marri <[email protected]>
>
> Add support code for bluestone board wth APM821XX processor based.
> This patch includes early board init, misc init, configure EBC,
> initializes UIC, MAKEALL, board.cfg and MAINTAINERS file.
>
> Signed-off-by: Tirumala R Marri <[email protected]
...
> --- /dev/null
> +++ b/include/configs/bluestone.h
> @@ -0,0 +1,178 @@
> +/*
> + * bluestone.h - configuration for Blouestone (APM821XX)
s/Blouestone/Bluestone/ ?
...
> +#define SPD_EEPROM_ADDRESS {0x53, 0x51} /* SPD i2c spd addresses */
...
> +#define CONFIG_SYS_I2C_SPEED 400000 /* I2C speed */
> +#define CONFIG_SYS_I2C_MULTI_EEPROMS
> +#define CONFIG_SYS_I2C_EEPROM_ADDR (0xa8 >> 1)
...
> +#define CONFIG_4xx_CONFIG_I2C_EEPROM_ADDR 0x52
Please replace the "(0xa8 >> 1)" by a plain 0x54 like youdo for the
other I2C addresses as well. No need to make reading more difficult
than necessary.
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
Real computer scientists don't comment their code. The identifiers
are so long they can't afford the disk space.
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
